On Mon, Sep 28, 2020 at 03:14:45PM +0100, Peter Maydell wrote: > On Mon, 28 Sep 2020 at 15:06, Daniel P. Berrangé <berra...@redhat.com> wrote: > > I think this can be simplified even more by using GLib's macros > > > > #define GCC_FMT_ATTR(n, m) G_GNUC_PRINTF(n, m) > > At least on my system G_GNUC_PRINTF() expands to > __format__(__printf__,...), not gnu_printf, so it is > not quite what we want. (The difference is that on Windows > hosts we still want to mark up our our logging functions as > taking the glibc style format handling, not whatever the > MS C library format escapes happen to be.) > At a minimum you'd need to keep in the "on Windows, > redefine __printf__ to __gnu_printf__" logic. > > See also commit 95df51a4a02a853.
Oh, that's a bug in old GLib versions. I thought we had a new enough min to avoid that problem, but i guess not after all. Modern GLib always uses gnu_printf even on Windows, as they're using a replacement GNU compatible printf impl for all the GLib APIs that take format strings. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
