On 08/10/2020 09.54, Philippe Mathieu-Daudé wrote: > Hi, > > On 10/8/20 8:05 AM, Chetan Pant wrote: >> There is no "version 2" of the "Lesser" General Public License. It is >> either "GPL version 2.0" or "LGPL version 2.1". This patch replaces all >> occurrences of "LGPL version 2" with "LGPL version 2.1" in comment section. > > This looks like a good cleanup! > > Since you already listed all the files using this license, > it can be a good opportunity to correct and use the full > license text (which is miswritten in various places): > > --- > > Copyright (C) <year> <name of author> > > This library is free software; you can redistribute it and/or modify it > under the terms of the GNU Lesser General Public License as published by > the Free Software Foundation; either version 2.1 of the License, or (at > your option) any later version. > > This library is distributed in the hope that it will be useful, but > WITHOUT ANY WARRANTY; without even the implied warranty of > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser > General Public License for more details. > > You should have received a copy of the GNU Lesser General Public License > along with this library; if not, write to the Free Software Foundation, > Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Please don't use that version. If the FSF move to another office again, we have to update the whole mess again. > Or simpler, add the SPDX identifier tag: > > SPDX-License-Identifier: LGPL-2.1-or-later SPDX tags would be cool, of course, but it could also be done in a separate patch later. Thomas
