On 10/8/20 10:49 AM, Daniel P. Berrangé wrote:
The bdrv_all_*_snapshot functions return a BlockDriverState pointer
for the invalid backend, which the callers then use to report an
error message. In some cases multiple callers are reporting the
same error message, but with slightly different text. In the future
there will be more error scenarios for some of these methods, which
will benefit from fine grained error message reporting. So it is
helpful to push error reporting down a level.
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
block/monitor/block-hmp-cmds.c | 7 ++--
block/snapshot.c | 77 +++++++++++++++++-----------------
include/block/snapshot.h | 14 +++----
migration/savevm.c | 37 +++++-----------
monitor/hmp-cmds.c | 7 +---
replay/replay-debugging.c | 4 +-
tests/qemu-iotests/267.out | 10 ++---
7 files changed, 67 insertions(+), 89 deletions(-)
and less code doesn't hurt either ;)
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
