On Mon, Oct 19, 2020 at 11:17:19AM +0900, Dmitry Fomichev wrote: > Add a new Boolean namespace property, "attached", to provide the most > basic namespace attachment support. The default value for this new > property is true. Also, implement the logic in the new CNS values to > include/exclude namespaces based on this new property. The only thing > missing is hooking up the actual Namespace Attachment command opcode, > which will allow a user to toggle the "attached" flag per namespace. > > The reason for not hooking up this command completely is because the > NVMe specification requires the namespace management command to be > supported if the namespace attachment command is supported.
Huh, the spec does require that, and that seems like an odd requirement since it prevents dynamic namespace attach states in a static namespace setup. I'm not sure why the spec assumes those two things go together, but it sure enough does! The implementation looks fine. Reviewed-by: Keith Busch <kbu...@kernel.org>
