On Fri, Oct 16, 2020 at 11:24:08AM +0200, Auger Eric wrote: > > + /* > > + * Set supported IOMMU page size > > + * > > + * If supported, allows to restrict the page size mask that can be > > supported > To match other docs: Optional method: > > + * with a given IOMMU memory region. For example, to propagate host > > physical > > + * IOMMU page size mask limitations to the virtual IOMMU. > > + * > > + * Returns 0 on success, or a negative error. In case of failure, the > > error > > + * object must be created. > document args as done for other functions?
I'll change this comment to: /** * @iommu_set_page_size_mask: * * Restrict the page size mask that can be supported with a given IOMMU * memory region. Used for example to propagate host physical IOMMU page * size mask limitations to the virtual IOMMU. * * Optional method: if this method is not provided, then the default global * page mask is used. * * @iommu: the IOMMUMemoryRegion * * @page_size_mask: a bitmask of supported page sizes. At least one bit, * representing the smallest page size, must be set. Additional set bits * represent supported block sizes. For example a host physical IOMMU that * uses page tables with a page size of 4kB, and supports 2MB and 4GB * blocks, will set mask 0x40201000. A granule of 4kB with indiscriminate * block sizes is specified with mask 0xfffffffffffff000. * * Returns 0 on success, or a negative error. In case of failure, the error * object must be created. */ Thanks, Jean