On Fri, Oct 16, 2020 at 03:08:03PM +0200, Auger Eric wrote: > > +static int virtio_iommu_set_page_size_mask(IOMMUMemoryRegion *mr, > > + uint64_t page_size_mask, > > + Error **errp) > > +{ > > + int new_granule, old_granule; > > + IOMMUDevice *sdev = container_of(mr, IOMMUDevice, iommu_mr); > > + VirtIOIOMMU *s = sdev->viommu; > > + > > + if (!page_size_mask) { > set errp
Woops, fixed > > + return -1; > > + } > > + > > + new_granule = ctz64(page_size_mask); > > + old_granule = ctz64(s->config.page_size_mask); > > I think this would be interesting to add a trace point Agreed Thanks, Jean