On Fri, Oct 23, 2020 at 03:33:31PM -0500, Eric Blake wrote: > On 10/23/20 3:06 PM, Daniele Buono wrote: > > v2: Several months (and structural changes in QEMU) have passed since v1. > > While the spirit of the patch is similar, the implementation is changed > > in multiple points, and should address most if not all the comments > > received in v1. > > > 5) Most of the logic to enable CFI goes in the configure, since it's > > just a matter of checking for dependencies and incompatible options. > > However, I had to disable CFI checks for a few TCG functions. > > This can only be done through a blacklist file. I added a file in the > > root of QEMU, called cfi-blacklist.txt for such purpose. I am open to > > suggestions on where the file should go, and I am willing to become the > > maintainer of it, if deemed necessary. > > In the meantime, we have commits like: > > commit b199c682f1f0aaee22b2170a5fb885250057eec2 > Author: Philippe Mathieu-Daudé <phi...@redhat.com> > Date: Thu Sep 10 09:01:31 2020 +0200 > > target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken() > > In order to use inclusive terminology, rename host_tsx_blacklisted() > as host_tsx_broken(). > > which may help you in coming up with a more appropriate name for the new > file.
Something like cfi-exclude-list.txt or cfi-skip-list.txt seems reasonable Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|