* no-re...@patchew.org (no-re...@patchew.org) wrote: > Patchew URL: > https://patchew.org/QEMU/20201026161952.149188-1-dgilb...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20201026161952.149188-1-dgilb...@redhat.com > Subject: [PULL 00/16] migration queue > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > - [tag update] > patchew/1603704987-20977-1-git-send-email-kwankh...@nvidia.com -> > patchew/1603704987-20977-1-git-send-email-kwankh...@nvidia.com > * [new tag] patchew/20201026161952.149188-1-dgilb...@redhat.com -> > patchew/20201026161952.149188-1-dgilb...@redhat.com > Switched to a new branch 'test' > eec7173 migration-test: Only hide error if !QTEST_LOG > 3cf5619 migration/postcopy: Release fd before going into 'postcopy-pause' > 05826d6 migration: Sync requested pages after postcopy recovery > e3ab9bd migration: Maintain postcopy faulted addresses > 94c47fd migration: Introduce migrate_send_rp_message_req_pages() > 37f5d13 migration: Pass incoming state into qemu_ufd_copy_ioctl() > d212778 migration: using trace_ to replace DPRINTF > 57fda59 migration: Delete redundant spaces > 5b093f1 migration: Open brace '{' following function declarations go on the > next line > 0b60dca migration: Do not initialise statics and globals to 0 or NULL > 2f219b6 migration: Add braces {} for if statement > 3fdcabc migration: Open brace '{' following struct go on the same line > 63bb26e migration: Add spaces around operator > fadaa39 migration: Don't use '#' flag of printf format > e568828 migration: Do not use C99 // comments > e477d01 migration: Drop unused VMSTATE_FLOAT64 support > > === OUTPUT BEGIN === > 1/16 Checking commit e477d010bf93 (migration: Drop unused VMSTATE_FLOAT64 > support) > 2/16 Checking commit e568828c0e63 (migration: Do not use C99 // comments) > 3/16 Checking commit fadaa39cfb42 (migration: Don't use '#' flag of printf > format) > 4/16 Checking commit 63bb26e930c4 (migration: Add spaces around operator) > ERROR: spaces required around that '*' (ctx:WxV) > #65: FILE: migration/savevm.c:523: > + .subsections = (const VMStateDescription *[]) { > ^ > > total: 1 errors, 0 warnings, 59 lines checked
We decided that was preferable > > Patch 4/16 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 5/16 Checking commit 3fdcabce2015 (migration: Open brace '{' following struct > go on the same line) > 6/16 Checking commit 2f219b67cf64 (migration: Add braces {} for if statement) > 7/16 Checking commit 0b60dca56f19 (migration: Do not initialise statics and > globals to 0 or NULL) > 8/16 Checking commit 5b093f15f482 (migration: Open brace '{' following > function declarations go on the next line) > 9/16 Checking commit 57fda592d44b (migration: Delete redundant spaces) > 10/16 Checking commit d21277810b4a (migration: using trace_ to replace > DPRINTF) > 11/16 Checking commit 37f5d13fa1bb (migration: Pass incoming state into > qemu_ufd_copy_ioctl()) > 12/16 Checking commit 94c47fdc32f4 (migration: Introduce > migrate_send_rp_message_req_pages()) > 13/16 Checking commit e3ab9bded382 (migration: Maintain postcopy faulted > addresses) > 14/16 Checking commit 05826d6ec62a (migration: Sync requested pages after > postcopy recovery) > 15/16 Checking commit 3cf5619e375b (migration/postcopy: Release fd before > going into 'postcopy-pause') > 16/16 Checking commit eec7173d989d (migration-test: Only hide error if > !QTEST_LOG) > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20201026161952.149188-1-dgilb...@redhat.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK