On Fri, Oct 30, 2020 at 12:00:33PM +0400, Marc-André Lureau wrote:
> On Fri, Oct 30, 2020 at 2:16 AM Eduardo Habkost <ehabk...@redhat.com> wrote:
> 
> > Make the code more generic and not specific to TYPE_DEVICE.
> >
> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
> >
> 
> What about dropping _qdev from the function name too?

I have a series that deletes the function completely, but I
decided to leave it outside of this first batch.

> 
> Also, I am not sure it's a well designed function.. I would rather have 3
> different helper functions than dispatching with an errno... Might be worth
> a TODO note :)
> 
> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>

Thanks!

-- 
Eduardo


Reply via email to