On Sun, Nov 01, 2020 at 02:03:56PM +0000, Peter Maydell wrote: > On Fri, 30 Oct 2020 at 14:33, <no-re...@patchew.org> wrote: > > > > Patchew URL: > > https://patchew.org/QEMU/20201030141136.1013521-1-...@redhat.com/ > > I'll apply this pullreq (unless it has other more serious > issues), but could you look at the coding style warnings in > a followup patch, please?
Will do, thanks! > > > 9/15 Checking commit 660b206b990b (pc: Implement -no-hpet as sugar for > > -machine hpet=on) > > WARNING: Block comments use a leading /* on a separate line > > #53: FILE: hw/i386/pc.c:1152: > > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 > > > > WARNING: Block comments should align the * on each line > > #54: FILE: hw/i386/pc.c:1153: > > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 > > + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, > > > > > 13/15 Checking commit e013e462e230 (vhost-blk: set features before setting > > inflight feature) > > ERROR: trailing whitespace > > #45: FILE: hw/virtio/vhost.c:1651: > > + $ > > > > ERROR: trailing whitespace > > #50: FILE: hw/virtio/vhost.c:1656: > > + $ > > These all look like nits that should be fixed. > > thanks > -- PMM
