Paolo Bonzini <pbonz...@redhat.com> writes:
> Right now, help options are parsed normally and then checked
> specially in opt_validate---but only if coming from
> qemu_opts_parse or qemu_opts_parse_noisily, not if coming
> from qemu_opt_set.
>
> Instead, move the check from opt_validate to the common workhorses
> of qemu_opts_parse and qemu_opts_parse_noisily, opts_do_parse and
> get_opt_name_value.
>
> This will come in handy in a subsequent patch, which will
> raise a warning for "-object memory-backend-ram,share"
> ("flag" option with no =on/=off part) but not for
> "-object memory-backend-ram,help".
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
I'm afraid this fails my smoke test:
$ o=`sed -n '/HAS_ARG,/s/DEF("\([^"]*\)".*/\1/p' qemu-options.hx`
$ for i in $o; do echo "= $i"; upstream-qemu -$i help -version; done 2>&1 |
egrep -v 'QEMU emulator|Copyright'
Many output differences. False positives due to help printing lists in
random order. Arbitrarily picked true positive:
$ upstream-qemu -msg help
msg options:
guest-name=<bool (on/off)> - Prepends guest name for error messages but
only if -name guest is set otherwise option is ignored
timestamp=<bool (on/off)>
$ echo $?
1
regresses to silent failure.
