On Mon, Nov 02, 2020 at 03:50:39PM +0100, Philippe Mathieu-Daudé wrote: > On 11/2/20 2:09 PM, Daniel P. Berrangé wrote: > > Meson runs a test to see if Sphinx works, and automatically disables it > > on error. This can lead to the CI jobs skipping docs build without > > maintainers noticing the problem. Use --enable-docs to force a fatal > > error if Sphinx doesn't work on the jobs where we expect it to be OK. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > .gitlab-ci.yml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > Shouldn't this patch go first in your series? Inverting 1<->2.
Doesn't really matter. The jobs already build docs. It was simply that in creating this series I inserted a bug that broke the detection of sphinx by configure and I didn't notice and wondered why docs were not being created. So I just added this as a safety net to make it easier to detect future messups. > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
