On 11/11/20 9:42 AM, Philippe Mathieu-Daudé wrote: > On 11/10/20 7:12 PM, Wainer dos Santos Moschetta wrote: >> >> On 11/8/20 6:45 PM, Philippe Mathieu-Daudé wrote: >>> Similarly to commit 8cdb2cef3f1, move the trace backend >>> tests to GitLab. >>> >>> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >>> --- >>> Cc: Stefan Hajnoczi <stefa...@redhat.com> >>> --- >>> .gitlab-ci.yml | 18 ++++++++++++++++++ >>> .travis.yml | 19 ------------------- >>> 2 files changed, 18 insertions(+), 19 deletions(-) >>> >>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >>> index 6552a832939..2f0da7b3dc1 100644 >>> --- a/.gitlab-ci.yml >>> +++ b/.gitlab-ci.yml >>> @@ -557,6 +557,24 @@ check-crypto-only-gnutls: >>> IMAGE: centos7 >>> MAKE_CHECK_ARGS: check >>> +# We don't need to exercise every backend with every front-end >>> +build-trace-multi-user: >>> + <<: *native_build_job_definition >>> + variables: >>> + IMAGE: ubuntu2004 >> >> Doesn't it need the lttng-ust-dev package in Ubuntu's image likewise you >> did for Fedora (patch 13)? > > No, because ... > >>> + CONFIGURE_ARGS: --enable-trace-backends=log,simple,syslog >>> --disable-system > > ... we don't build the User-Space Tracer there. > >>> + >>> +build-trace-ftrace-system: >>> + <<: *native_build_job_definition >>> + variables: >>> + IMAGE: ubuntu2004 >>> + CONFIGURE_ARGS: --enable-trace-backends=ftrace >>> --target-list=aarch64-softmmu >> On Travis it builds the x86_64 softmmu target. Changed to aarch64 to >> increase coverage? > > Maybe because the next job already test this target? I'll change. > >>> + >>> +build-trace-ust-system: >>> + <<: *native_build_job_definition >>> + variables: >>> + IMAGE: fedora >> >> Similar question here, increasing coverage by using Fedora? > > No, because User-Space Tracer is a feature Red Hat cares > about, and plan to maintain, so it makes sense to test it > on Fedora. I'll comment this change in the description.
Bah, this is a different change in itself, out of the scope of this series. I'll keep Ubuntu image. Whoever is interested to test this on Fedora can add a proper job. Thanks.