On Thu, Nov 12, 2020 at 03:32:58PM +0100, Max Reitz wrote: > On 11.11.20 13:43, Stefan Hajnoczi wrote: > > The function is used not just for image files but also for UNIX domain > > sockets (QMP monitor and vhost-user-blk). Reflect that in the name. > > > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > --- > > tests/qtest/vhost-user-blk-test.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > [...] > > > @@ -731,7 +732,7 @@ static char *start_vhost_user_blk(GString *cmd_line, > > int vus_instances, > > sock_path = g_strdup(sock_path_tempate); > > fd = mkstemp(sock_path); > > g_assert_cmpint(fd, >=, 0); > > - g_test_queue_destroy(drive_destroy, sock_path); > > + g_test_queue_destroy(drive_file, sock_path); > > s/drive_file/destroy_file/, I think :)
Oops! The following commit removes this line so I didn't notice this issue: "vhost-user-blk-test: fix races by using fd passing". Michael: If you want this intermediate commit fixed for bisectability I will respin. Otherwise the patches in your tree are fine.
signature.asc
Description: PGP signature
