On 18/11/20 14:08, Markus Armbruster wrote:
These look like errors, but aren't; things are working exactly as
intended, and QEMU runs. If we want to be chatty about it, we should
make them info, not error.
If there were an info_report, I would have sent a patch already. :) In
general, these are probably not the only cases where error_report is
used as a fancy fprintf(stderr), rather than to report actual errors.
Paolo
Same with /dev/kvm made inaccessible:
$ qemu-system-x86_64 -accel xen -S -accel nonexistent -accel kvm
[Xen chatter...]
qemu-system-x86_64: -accel xen: failed to initialize xen: Operation not
permitted
qemu-system-x86_64: -accel nonexistent: invalid accelerator nonexistent
Could not access KVM kernel module: Permission denied
qemu-system-x86_64: -accel kvm: failed to initialize kvm: Permission denied
Here, we do have a fatal error. We report it as four errors.
Tolerable.
If we turn the maybe-not-really-errors into info to make the first
example less confusing, we need to report a "no accelerator works" error
at the end.
