Philippe Mathieu-Daudé <phi...@redhat.com> writes: > On 11/18/20 10:03 AM, Thomas Huth wrote: >> Both headers, sysbus.h and module.h, are not required to compile this file.
module.h is: it defines type_init(). >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> hw/watchdog/wdt_diag288.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdog/wdt_diag288.c >> index 71a945f0bd..4c4b6a6ab7 100644 >> --- a/hw/watchdog/wdt_diag288.c >> +++ b/hw/watchdog/wdt_diag288.c >> @@ -14,12 +14,10 @@ >> #include "qemu/osdep.h" >> #include "sysemu/reset.h" >> #include "sysemu/watchdog.h" >> -#include "hw/sysbus.h" > > OK > >> #include "qemu/timer.h" >> #include "hw/watchdog/wdt_diag288.h" >> #include "migration/vmstate.h" >> #include "qemu/log.h" >> -#include "qemu/module.h" > > Cc'ing Markus because of: > > commit 0b8fa32f551e863bb548a11394239239270dd3dc > Author: Markus Armbruster <arm...@redhat.com> > Date: Thu May 23 16:35:07 2019 +0200 > > Include qemu/module.h where needed, drop it from qemu-common.h If it still compiles and links, it must get it via some other header. >> >> static WatchdogTimerModel model = { >> .wdt_name = TYPE_WDT_DIAG288, >>