On Thu, Nov 19, 2020 at 09:44:48AM +0100, Gerd Hoffmann wrote:
> Add source set to trace_events_config, use it in trace/meson.build
> so the trace objects are linked to the module not core qemu.
>
> Not working as intended.
> /me looks puzzled.
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
> hw/display/meson.build | 1 +
> trace/meson.build | 9 +++++----
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/hw/display/meson.build b/hw/display/meson.build
> index c2fc36e19d3e..94e355ac1e81 100644
> --- a/hw/display/meson.build
> +++ b/hw/display/meson.build
> @@ -46,6 +46,7 @@ if config_all_devices.has_key('CONFIG_QXL')
> trace_events_config += {
> 'file' : meson.source_root() / 'hw' / 'display' / 'trace-events-qxl',
> 'group' : 'hw_display_qxl',
> + 'ss' : qxl_ss,
> }
> hw_display_modules += {'qxl': qxl_ss}
> endif
> diff --git a/trace/meson.build b/trace/meson.build
> index 66395d3e2ba7..3f0fe7b7b74c 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -18,6 +18,7 @@ foreach c : trace_events_config
> trace_events_files += [ trace_events_file ]
> group = '--group=' + c.get('group')
> fmt = '@0@-' + c.get('group') + '.@1@'
> + module_ss = c.get('ss', trace_ss)One idea: module_ss is already used in other files. Are you sure there isn't an identifier naming conflict?
signature.asc
Description: PGP signature
