On 20/11/20 16:34, Igor Mammedov wrote:
qapi_event_send_migration(MIGRATION_STATUS_SETUP); - if (!strcmp(uri, "defer")) { - deferred_incoming_migration(errp); - } else if (strstart(uri, "tcp:", &p) || - strstart(uri, "unix:", NULL) || - strstart(uri, "vsock:", NULL)) {considering the last hunk does won't call qmp_migrate_incoming if 'defer' was used, wouldn't we will lose QAPI event here? not sure how important it to users,
Hmm yeah that's true. That might even be considered a bugfix (no setup is done until the "real" migrate-incoming command), but I can also add the event manually in qemu_init.
(Libvirt doesn't use the SETUP case of the event but that's of course only part of the story).
Paolo
