Paolo Bonzini <pbonz...@redhat.com> writes: > On 01/12/20 16:00, P J P wrote: [...] >> * I did test it against a reproducer, but did not get to the qtest >> part for >> the time constraints. > > qtests are not just helpful. Adding regression tests for bugs is a > *basic* software engineering principle. If you don't have time to > write tests, you (or your organization) should find it. > > But even if you don't write tests you need at least to enclose the > reproducer, otherwise you're posting a puzzle not a patch. :)
Indeed. Posting puzzles is a negative-sum game. You save a little time, but your reviewers have to pay back, with usurious interest. Depending on how nice they are, they may even do it a few times for you, but eventually even the nicest ones will take one look at your patch, and bounce it right back to you. Mission accomplished: all terms in the negative sum are now negative.
