On Thu, Aug 25, 2011 at 3:31 PM, Avi Kivity <a...@redhat.com> wrote: >> Hi, >> >> I see that x86 CPU topology inside VM is not showing up as specified. >> With some debugging, I found out that the root cause for this: qemu is >> not enumerating the apic ids correctly for vcpus. I made the below >> hackish change to get it working. Has anybody else seen this problem >> ? This patch is on qemu-kvm-0.14.1. Using 2.6.39 for guest. >> > >> Index: qemu-kvm-0.14.1/hw/pc.c >> =================================================================== >> --- qemu-kvm-0.14.1.orig/hw/pc.c >> +++ qemu-kvm-0.14.1/hw/pc.c > > Please post a patch against qemu.git master branch.
Sure I will rebase. The previous version was just a quick and hackish change, I just wanted pass by the list. > >> >> + if (env->cpuid_features & CPUID_APIC) >> + env->cpuid_apic_id = env->cpu_index; >> + > > qemu coding style requires braces even around single statements in if () > blocks. Sure. Thanks, Bharata.
