Patchew URL: https://patchew.org/QEMU/20201207073327.33367-1-...@ozlabs.ru/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201207073327.33367-1-...@ozlabs.ru Subject: [PATCH qemu v11] spapr: Implement Open Firmware client interface === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201207073327.33367-1-...@ozlabs.ru -> patchew/20201207073327.33367-1-...@ozlabs.ru Switched to a new branch 'test' fd4b6bc spapr: Implement Open Firmware client interface === OUTPUT BEGIN === WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #223: new file mode 100644 ERROR: code indent should never use tabs #1354: FILE: pc-bios/vof/bootmem.c:5: +^Iuint64_t kern[2];$ ERROR: code indent should never use tabs #1355: FILE: pc-bios/vof/bootmem.c:6: +^Iphandle chosen = ci_finddevice("/chosen");$ ERROR: code indent should never use tabs #1357: FILE: pc-bios/vof/bootmem.c:8: +^Iif (ci_getprop(chosen, "qemu,boot-kernel", kern, sizeof(kern)) !=$ ERROR: code indent should never use tabs #1358: FILE: pc-bios/vof/bootmem.c:9: +^I^I^Isizeof(kern))$ ERROR: code indent should never use tabs #1359: FILE: pc-bios/vof/bootmem.c:10: +^I^Ireturn;$ ERROR: code indent should never use tabs #1361: FILE: pc-bios/vof/bootmem.c:12: +^Ido_boot(kern[0], initrd, initrdsize);$ ERROR: externs should be avoided in .c files #1380: FILE: pc-bios/vof/ci.c:12: +extern uint32_t ci_entry(uint32_t params); ERROR: externs should be avoided in .c files #1382: FILE: pc-bios/vof/ci.c:14: +extern unsigned long hv_rtas(unsigned long params); ERROR: externs should be avoided in .c files #1383: FILE: pc-bios/vof/ci.c:15: +extern unsigned int hv_rtas_size; ERROR: code indent should never use tabs #1387: FILE: pc-bios/vof/ci.c:19: +^Ivoid *rtasbase;$ ERROR: code indent should never use tabs #1388: FILE: pc-bios/vof/ci.c:20: +^Iuint32_t rtassize = 0;$ ERROR: code indent should never use tabs #1389: FILE: pc-bios/vof/ci.c:21: +^Iphandle rtas;$ ERROR: code indent should never use tabs #1391: FILE: pc-bios/vof/ci.c:23: +^Iif (strcmp("call-method", (void *)(unsigned long) pargs->service))$ ERROR: braces {} are necessary for all arms of this statement #1391: FILE: pc-bios/vof/ci.c:23: + if (strcmp("call-method", (void *)(unsigned long) pargs->service)) [...] ERROR: code indent should never use tabs #1392: FILE: pc-bios/vof/ci.c:24: +^I^Ireturn false;$ ERROR: code indent should never use tabs #1394: FILE: pc-bios/vof/ci.c:26: +^Iif (strcmp("instantiate-rtas", (void *)(unsigned long) pargs->args[0]))$ ERROR: braces {} are necessary for all arms of this statement #1394: FILE: pc-bios/vof/ci.c:26: + if (strcmp("instantiate-rtas", (void *)(unsigned long) pargs->args[0])) [...] ERROR: code indent should never use tabs #1395: FILE: pc-bios/vof/ci.c:27: +^I^Ireturn false;$ ERROR: code indent should never use tabs #1397: FILE: pc-bios/vof/ci.c:29: +^Irtas = ci_finddevice("/rtas");$ ERROR: code indent should never use tabs #1398: FILE: pc-bios/vof/ci.c:30: +^Ici_getprop(rtas, "rtas-size", &rtassize, sizeof(rtassize));$ ERROR: code indent should never use tabs #1399: FILE: pc-bios/vof/ci.c:31: +^Iif (rtassize < hv_rtas_size)$ ERROR: braces {} are necessary for all arms of this statement #1399: FILE: pc-bios/vof/ci.c:31: + if (rtassize < hv_rtas_size) [...] ERROR: code indent should never use tabs #1400: FILE: pc-bios/vof/ci.c:32: +^I^Ireturn false;$ ERROR: code indent should never use tabs #1402: FILE: pc-bios/vof/ci.c:34: +^Irtasbase = (void *)(unsigned long) pargs->args[2];$ ERROR: code indent should never use tabs #1404: FILE: pc-bios/vof/ci.c:36: +^Imemcpy(rtasbase, hv_rtas, hv_rtas_size);$ ERROR: code indent should never use tabs #1405: FILE: pc-bios/vof/ci.c:37: +^Ipargs->args[pargs->nargs] = 0;$ ERROR: code indent should never use tabs #1406: FILE: pc-bios/vof/ci.c:38: +^Ipargs->args[pargs->nargs + 1] = pargs->args[2];$ ERROR: code indent should never use tabs #1408: FILE: pc-bios/vof/ci.c:40: +^Ireturn true;$ ERROR: code indent should never use tabs #1413: FILE: pc-bios/vof/ci.c:45: +^Iif (!prom_handle((void *)(unsigned long) args))$ ERROR: braces {} are necessary for all arms of this statement #1413: FILE: pc-bios/vof/ci.c:45: + if (!prom_handle((void *)(unsigned long) args)) [...] ERROR: code indent should never use tabs #1414: FILE: pc-bios/vof/ci.c:46: +^I^Ici_entry(args);$ ERROR: braces {} are necessary for all arms of this statement #1428: FILE: pc-bios/vof/ci.c:60: + for (i = 0; i < nargs; i++) [...] ERROR: braces {} are necessary for all arms of this statement #1432: FILE: pc-bios/vof/ci.c:64: + for (i = 0; i < nret; i++) [...] ERROR: spaces required around that '+' (ctx:VxV) #1433: FILE: pc-bios/vof/ci.c:65: + args.args[nargs+i] = 0; ^ ERROR: braces {} are necessary for all arms of this statement #1435: FILE: pc-bios/vof/ci.c:67: + if (ci_entry((uint32_t)(&args)) < 0) [...] ERROR: code indent should never use tabs #1443: FILE: pc-bios/vof/ci.c:75: +^Icall_prom("exit", 0, 0);$ ERROR: code indent should never use tabs #1448: FILE: pc-bios/vof/ci.c:80: +^Ireturn call_prom("finddevice", 1, 1, path);$ ERROR: code indent should never use tabs #1453: FILE: pc-bios/vof/ci.c:85: +^Ireturn call_prom("getprop", 4, 1, ph, propname, prop, len);$ ERROR: code indent should never use tabs #1458: FILE: pc-bios/vof/ci.c:90: +^Ireturn call_prom("open", 1, 1, path);$ ERROR: code indent should never use tabs #1463: FILE: pc-bios/vof/ci.c:95: +^Icall_prom("close", 1, 0, ih);$ ERROR: code indent should never use tabs #1468: FILE: pc-bios/vof/ci.c:100: +^Iuint32_t ret = call_prom("claim", 3, 1, ADDR(virt), size, align);$ ERROR: code indent should never use tabs #1470: FILE: pc-bios/vof/ci.c:102: +^Ireturn (void *) (unsigned long) ret;$ ERROR: code indent should never use tabs #1475: FILE: pc-bios/vof/ci.c:107: +^Ireturn call_prom("release", 2, 1, ADDR(virt), size);$ ERROR: code indent should never use tabs #1598: FILE: pc-bios/vof/libc.c:5: +^Iint len = 0;$ ERROR: code indent should never use tabs #1600: FILE: pc-bios/vof/libc.c:7: +^Iwhile (*s != 0) {$ ERROR: code indent should never use tabs #1601: FILE: pc-bios/vof/libc.c:8: +^I^Ilen += 1;$ ERROR: code indent should never use tabs #1602: FILE: pc-bios/vof/libc.c:9: +^I^Is += 1;$ ERROR: code indent should never use tabs #1603: FILE: pc-bios/vof/libc.c:10: +^I}$ ERROR: code indent should never use tabs #1605: FILE: pc-bios/vof/libc.c:12: +^Ireturn len;$ ERROR: braces {} are necessary for all arms of this statement #1611: FILE: pc-bios/vof/libc.c:18: + if (*s1 != *s2) [...] ERROR: braces {} are necessary for all arms of this statement #1639: FILE: pc-bios/vof/libc.c:46: + if (*p1 != *p2) [...] ERROR: return is not a function, parentheses are not required #1640: FILE: pc-bios/vof/libc.c:47: + return (*p1 - *p2); ERROR: else should follow close brace '}' #1663: FILE: pc-bios/vof/libc.c:70: + } + else { ERROR: code indent should never use tabs #1696: FILE: pc-bios/vof/main.c:6: +^Iregister unsigned long r3 __asm__("r3") = _r3;$ ERROR: code indent should never use tabs #1697: FILE: pc-bios/vof/main.c:7: +^Iregister unsigned long r4 __asm__("r4") = _r4;$ ERROR: code indent should never use tabs #1698: FILE: pc-bios/vof/main.c:8: +^Iregister unsigned long r5 __asm__("r5") = (unsigned long) _prom_entry;$ ERROR: code indent should never use tabs #1700: FILE: pc-bios/vof/main.c:10: +^I((client *)(uint32_t)addr)();$ ERROR: code indent should never use tabs #1705: FILE: pc-bios/vof/main.c:15: +^Iregister unsigned long r3 __asm__("r3");$ ERROR: code indent should never use tabs #1706: FILE: pc-bios/vof/main.c:16: +^Iregister unsigned long r4 __asm__("r4");$ ERROR: code indent should never use tabs #1707: FILE: pc-bios/vof/main.c:17: +^Iregister unsigned long r5 __asm__("r5");$ ERROR: code indent should never use tabs #1708: FILE: pc-bios/vof/main.c:18: +^Iuint64_t initrd = r3, initrdsize = r4;$ ERROR: code indent should never use tabs #1710: FILE: pc-bios/vof/main.c:20: +^Iboot_from_memory(initrd, initrdsize);$ ERROR: code indent should never use tabs #1711: FILE: pc-bios/vof/main.c:21: +^Ici_panic("*** No boot target ***\n");$ total: 63 errors, 1 warnings, 1601 lines checked Commit fd4b6bc1f18a (spapr: Implement Open Firmware client interface) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201207073327.33367-1-...@ozlabs.ru/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com