On Thu, 2020-12-10 at 01:09 +0100, Paolo Bonzini wrote: > On 09/12/20 15:03, no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/20201209135355.561745-1-mlevi...@redhat.com/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Message-id: 20201209135355.561745-1-mlevi...@redhat.com > > Subject: [PATCH v2 0/5] SCSI: fix transfer limits for SCSI passthrough > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > git rev-parse base > /dev/null || exit 0 > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > git config --local diff.algorithm histogram > > ./scripts/checkpatch.pl --mailback base.. > > === TEST SCRIPT END === > > > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > From https://github.com/patchew-project/qemu > > * [new tag] patchew/20201209135355.561745-1-mlevi...@redhat.com > > -> patchew/20201209135355.561745-1-mlevi...@redhat.com > > Switched to a new branch 'test' > > 77c9000 block/scsi: correctly emulate the VPD block limits page > > 61f49e1 block: use blk_get_max_ioctl_transfer for SCSI passthrough > > 35c66d6 block: add max_ioctl_transfer to BlockLimits > > 08ba263 file-posix: add sg_get_max_segments that actually works with sg > > e9fd749 file-posix: split hdev_refresh_limits from raw_refresh_limits > > > > === OUTPUT BEGIN === > > 1/5 Checking commit e9fd7498060c (file-posix: split hdev_refresh_limits > > from raw_refresh_limits) > > 2/5 Checking commit 08ba263f565d (file-posix: add sg_get_max_segments that > > actually works with sg) > > 3/5 Checking commit 35c66d636d83 (block: add max_ioctl_transfer to > > BlockLimits) > > 4/5 Checking commit 61f49e1c953b (block: use blk_get_max_ioctl_transfer for > > SCSI passthrough) > > 5/5 Checking commit 77c9000b7c30 (block/scsi: correctly emulate the VPD > > block limits page) > > ERROR: braces {} are necessary for all arms of this statement > > #39: FILE: hw/scsi/scsi-generic.c:204: > > + if (len < r->buflen) > > [...] > > > > total: 1 errors, 0 warnings, 28 lines checked > > > > Patch 5/5 has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > > > === OUTPUT END === > > > > Test command exited with code: 1 > > > > > > The full log is available at > > http://patchew.org/logs/20201209135355.561745-1-mlevi...@redhat.com/testing.checkpatch/?type=message. > > --- > > Email generated automatically by Patchew [https://patchew.org/]. > > Please send your feedback to patchew-de...@redhat.com > > > > Time for v3?
I am waiting a bit to see if anything else pops up, to avoid doing too much noise. Best regards, Maxim Levitsky > > Paolo >