On Fri, 11 Dec 2020 at 16:12, Leif Lindholm <l...@nuviainc.com> wrote: > > On Fri, Dec 11, 2020 at 14:45:55 +0000, Peter Maydell wrote: > > On Tue, 8 Dec 2020 at 12:23, Leif Lindholm <l...@nuviainc.com> wrote: > > > > > > Signed-off-by: Leif Lindholm <l...@nuviainc.com>
> > > +FIELD(CCSIDR_EL1, ASSOCIATIVITY, 3, 20) > > > > The ASSOCIATIVITY field is bits [23:3], so it's > > 21 bits long, not 20, right ? > > Err, indeed. > > > > +FIELD(CCSIDR_EL1, NUMSETS, 32, 23) > > > > Similarly, NUMSETS is [55:32] so 24 bits long. > > Sorry, brain must have taken holiday. > > Would you like a v2 of this patch, fixing those? Yes please. > > > + > > > +FIELD(CTR_EL0, IMINLINE, 0, 4) > > > +FIELD(CTR_EL0, L1IP, 14, 2) > > > +FIELD(CTR_EL0, DMINLINE, 16, 4) > > > +FIELD(CTR_EL0, ERG, 20, 4) > > > +FIELD(CTR_EL0, CWG, 24, 4) > > > +FIELD(CTR_EL0, IDC, 28, 1) > > > +FIELD(CTR_EL0, DIC, 29, 1) > > > + > > > FIELD(MIDR_EL1, REVISION, 0, 4) > > > FIELD(MIDR_EL1, PARTNUM, 4, 12) > > > FIELD(MIDR_EL1, ARCHITECTURE, 16, 4) > > > > Any reason not to define the other fields here? > > FIELD(MIDR_EL1, VARIANT, 20, 4) > > FIELD(MIDR_EL1, IMPLEMENTER, 24, 8) > > Those are just context, not added by this patch. > (Glad to see I'm not the only one making that mistake...) Doh! thanks -- PMM
