On Mon, 14 Dec 2020 at 18:11, Rebecca Cran <rebe...@nuviainc.com> wrote: > > On 12/11/20 2:37 PM, Peter Maydell wrote: > > On Fri, 11 Dec 2020 at 19:51, Richard Henderson > > <richard.hender...@linaro.org> wrote: > >> I'll let Peter weigh in, but I think it makes sense to move the SS bit > >> somewhere else (e.g. env->pstate) and merge it into SPSR_ELx upon > >> interrupt. > >> While what we're doing here is convenient, it's not architectural, and it > >> would > >> be better to follow GetPSRFromPSTATE pseudocode. > > > > Yes, I think that's the best thing to do. We've been skating > > by on CPSR and SPSR being the same thing and it's just > > stopped working. > > Would you like me to work on this, or is it something the arm > maintainers would fix?
You're the person that wants to add the change that requires this refactoring, so if you could, I think the best thing would be for you to do this bit of work and send it as part of this patchseries. thanks -- PMM