Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

[Richard Henderson]

On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote:
> +bool isa_rel6_available(const CPUMIPSState *env)
> +{
> +    if (TARGET_LONG_BITS == 64) {
> +        return cpu_supports_isa(env, ISA_MIPS64R6);
> +    }
> +    return cpu_supports_isa(env, ISA_MIPS32R6);
> +}

So... does qemu-system-mips64 support 32-bit cpus?

If so, this needs to be written

  if (TARGET_LONG_BITS == 64 && cpu_supports_isa(...)) {
    return true;
  }

Otherwise, this will return false for a mips32r6 cpu.


r~