John Snow <js...@redhat.com> writes: > QAPIGenC and QAPIGenH in particular depend on fname being defined, but > we have a usage of QAPIGenCCode that isn't intended to be associated > with a particular file.
Which one? Hmm, it's this one: class QAPISchemaGenCommandVisitor(QAPISchemaModularCVisitor): def __init__(self, prefix: str): super().__init__( prefix, 'qapi-commands', ' * Schema-defined QAPI/QMP commands', None, __doc__) ---> self._regy = QAPIGenCCode(None) self._visited_ret_types: Dict[QAPIGenC, Set[QAPISchemaType]] = {} Let me try to get rid of it. > No problem, move the write method down to the class that actually needs > it, and keep QAPIGenCCode more abstract. > > Signed-off-by: John Snow <js...@redhat.com>