"Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Commit 8118f0950f "migration: Append JSON description of migration >> stream" needs a JSON writer. The existing qobject_to_json() wasn't a >> good fit, because it requires building a QObject to convert. Instead, >> migration got its very own JSON writer, in commit 190c882ce2 "QJSON: >> Add JSON writer". It tacitly limits numbers to int64_t, and strings >> contents to characters that don't need escaping, unlike >> qobject_to_json(). >> >> The previous commit factored the JSON writer out of qobject_to_json(). >> Replace migration's JSON writer by it. >> >> Cc: Juan Quintela <quint...@redhat.com> >> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > (Copying in Alex) > > This looks OK to me, so: > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > but, can I just check, have you checked scripts/analyze-migration.py is > still happy with the output?
Good point. I just did, following instructions in docs/devel/migration.rst. It prints stuff and succeeds. Anything else you'd like me to try?
