Max Reitz <mre...@redhat.com> writes:
> On 17.12.20 17:19, Markus Armbruster wrote:
>> Some of the next commits will checksum structs. Change vpc_checksum()
>> to take void * instead of uint8_t, to save us pointless casts to
>> uint8_t *.
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> block/vpc.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> diff --git a/block/vpc.c b/block/vpc.c
>> index 34186640ee..5af9837806 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -172,8 +172,9 @@ static QemuOptsList vpc_runtime_opts = {
>> static QemuOptsList vpc_create_opts;
>> -static uint32_t vpc_checksum(uint8_t *buf, size_t size)
>> +static uint32_t vpc_checksum(void *p, size_t size)
>> {
>> + uint8_t *buf = p;
>> uint32_t res = 0;
>> int i;
>
> Using this opportunity to add consts would be nice, but not necessary:
Didn't think of it, missed opportunity. Not worth a respin all by
itself, I think. I'm fine with the maintainer adding const.
> Reviewed-by: Max Reitz <mre...@redhat.com>
Thanks!
