On 12/16/20 4:06 PM, Darrin M. Gorski wrote: > This patch adds a 'modemctl' option to "-chardev socket" to enable control > of the socket via the guest serial port. > The default state of the option is disabled. > > 1. disconnect a connected socket when DTR transitions to low, also reject > new connections while DTR is low. > 2. provide socket connection status through the carrier detect line (CD or > DCD) on the guest serial port > > Buglink: https://bugs.launchpad.net/qemu/+bug/1213196 > > Signed-off-by: Darrin M. Gorski <dar...@gorski.net> > > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c
Hmm - your workflow did not produce the usual --- marker and a diffstat of which files were in the patch; this makes it easier for reviewers to see at a glance what the rest of the email will contain. It's not essential, but it does help. > +++ b/qapi/char.json > @@ -271,6 +271,9 @@ > # then attempt a reconnect after the given number of seconds. > # Setting this to zero disables this function. (default: 0) > # (Since: 2.2) > +# @modemctl: allow guest to use modem control signals to control/monitor > +# the socket state (CD follows is_connected, DTR influences > +# connect/accept) (default: false) (Since: 5.2) The next release will by 6.0, not 5.2. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
