On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote: > On 10/13/20 4:38 PM, Claudio Fontana wrote: >> This series now unbreaks current non-tcg builds >> (!CONFIG_TCG). >> >> tests Makefiles need to avoid relying on all non-native >> archs binaries to be present, >> >> bios-tables-test needs to skip tests that are tcg-only, >> >> and notably the replay framework needs to consider that >> it might not be functional (or its code present at all) >> without TCG. >> >> Tested ok target x86_64-softmmu on x86_64 host with: >> >> ./configure --enable-tcg --disable-kvm >> ./configure --enable-kvm --disable-tcg >> ./configure --enable-tcg --enable-kvm > > If you want to avoid these configurations to bitrot, > consider covering them by adding Gitlab jobs :))) >
Hello Philippe, happy new year, I am going back to look at the current code in master, slowly trying to get back a hold on things, and I remember some time ago you suggested to keep testing "tools" builds, with ./configure --disable-tcg --disable-kvm --enable-tools but the drawback of the "tools-only" build is that currently one cannot run make check on it. It fails with ERRORS in bios-tables-test and others. Is it supposed to actually work? Is there any make check work that can be done without any accelerator? I would assume so... Thanks, Claudio