On 1/10/21 6:27 AM, Philippe Mathieu-Daudé wrote: > The tcg_out* functions are utility routines that may or > may not be used by a particular backend. Similarly to commit > 4196dca63b8, mark them with the 'unused' attribute to suppress > spurious warnings if they aren't used. > > This fixes the build with --enable-tcg-interpreter: > > [98/151] Compiling C object libqemu-arm-softmmu.fa.p/tcg_tcg.c.o > FAILED: libqemu-arm-softmmu.fa.p/tcg_tcg.c.o > clang [...] -o libqemu-arm-softmmu.fa.p/tcg_tcg.c.o -c ../tcg/tcg.c > ../tcg/tcg.c:136:20: error: unused function 'tcg_out_dupi_vec' > [-Werror,-Wunused-function] > > Reported-by: Wataru Ashihara <wata...@wataash.com> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > tcg/tcg.c | 30 +++++++++++++++++++++--------- > 1 file changed, 21 insertions(+), 9 deletions(-)
This does too much to fix that Werror, as all of the other functions are unconditionally used. Alternately, I'll re-test and merge my tcg constant branch, which will make tcg_out_dupi_vec also unconditionally used. Then we don't need __attribute__((unused)) at all. r~
