> >> +{ 'command': 'change-vnc-authz',
> >> + 'data': { 'type' : 'str',
> >> + 'index': 'str'},
> >> + 'if': 'defined(CONFIG_VNC_SASL)' }
> >
> > type should be an enum I think.
> It is a good idea to set type to enum, I will fix it in the next version.
>
> > Also index should be an int (and possibly an optional argument so you
> > can just not specify index to unset).
> >
> Index is the id of authz object(myauthz, user can set it as they wanted), may
> not use int.
> -object authz-simple,id=myauthz,identity=test1
Name it "auth-id" then? "index" sounds like a number ...
> BTW, Daniel P . Berrangé suggests that all property set QMP commands should
> be integrated
> as an general purpose "display_update" QMP command. That's really a good idea.
Makes sense indeed.
take care,
Gerd
