Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add TestEnv class, which will handle test environment in a new python > iotests running framework. > > Difference with current ./check interface: > - -v (verbose) option dropped, as it is unused > > - -xdiff option is dropped, until somebody complains that it is needed > - same for -n option > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
+************* Module testenv +testenv.py:48:0: R0902: Too many instance attributes (34/7) (too-many-instance-attributes) +testenv.py:212:16: R1722: Consider using sys.exit() (consider-using-sys-exit) +testenv.py:214:16: R1722: Consider using sys.exit() (consider-using-sys-exit) +testenv.py:324:8: R1722: Consider using sys.exit() (consider-using-sys-exit) +testenv.py:1:0: R0801: Similar lines in 2 files +==findtests:45 +==testenv:72 + _argparser = None + @classmethod + def get_argparser(cls) -> argparse.ArgumentParser: + if cls._argparser is not None: + return cls._argparser + (duplicate-code) +testenv.py:294: error: Function is missing a type annotation for one or more arguments I wonder whether we should just disable the "similar lines" check? The instance attributes one looks kind of arbitrary, too. The rest looks valid enough. Kevin
