On 1/13/21 8:10 AM, Max Reitz wrote: > On 13.01.21 15:06, Max Reitz wrote: >> Throttling on the BB has not affected block jobs in a while, so it is >> possible that one of the jobs in 129 finishes before the VM is stopped. >> We can fix that by running the job from a throttle node. >> >> Signed-off-by: Max Reitz <mre...@redhat.com> >> --- >> tests/qemu-iotests/129 | 39 +++++++++++++++------------------------ >> 1 file changed, 15 insertions(+), 24 deletions(-) >>
>> result = self.vm.qmp("stop") >> self.assert_qmp(result, 'return', {}) >> result = self.vm.qmp("query-block-jobs") >> + >> self.assert_qmp(result, 'return[0]/status', 'running') >> self.assert_qmp(result, 'return[0]/ready', False) >> + self.vm.qmp("block-job-cancel", device="drive0", force=True) >> + > > Sorry, somewhere along the way I forgot to remove this block-job-cancel. > It’s still from > https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg00499.html > and I don’t know why I added it there. It should probably go. > > ('stop' should have drained, that’s the point, so there shouldn’t be any > further delay if we quit the VM without cancelling the job.) Since the test still passes without the added block-job-cancel, I'm fine with removing that line then adding: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org