On Thu, 14 Jan 2021 17:17:48 -0500
Alexander Bulekov <alx...@bu.edu> wrote:
> Signed-off-by: Alexander Bulekov <alx...@bu.edu>
> ---
No changelog at all ?
> tests/qtest/fuzz/generic_fuzz_configs.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h
> b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 7fed035345..ffdb590c58 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -59,6 +59,18 @@ const generic_fuzz_config predefined_configs[] = {
> .name = "virtio-mouse",
> .args = "-machine q35 -nodefaults -device virtio-mouse",
> .objects = "virtio*",
> + },{
> + .name = "virtio-9p",
> + .args = "-machine q35 -nodefaults "
> + "-device virtio-9p,fsdev=hshare,mount_tag=hshare "
> + "-fsdev local,id=hshare,path=/tmp/,security_model=none",
Sharing a general purpose directory like "/tmp" is definitely not a
recommended practice. This is typically the kind of thing that I'd
like to see documented in the changelog to help me understand ;-)
What operations does the fuzz test perform on the device ?
> + .objects = "virtio*",
> + },{
> + .name = "virtio-9p-synth",
> + .args = "-machine q35 -nodefaults "
> + "-device virtio-9p,fsdev=hshare,mount_tag=hshare "
> + "-fsdev synth,id=hshare",
> + .objects = "virtio*",
Not sure this is super useful since the only known use case for
the synth fsdev driver is running the virtio-9p qtest, but
it looks fine anyway.
> },{
> .name = "e1000",
> .args = "-M q35 -nodefaults "
