On Wed, 13 Jan 2021 10:46:27 +0800 leirao <lei....@intel.com> wrote: > From: "Rao, Lei" <lei....@intel.com> > > This patch fixes the following: > qemu-system-x86_64: invalid runstate transition: 'colo' ->'shutdown' > Aborted (core dumped) > > Signed-off-by: Lei Rao <lei....@intel.com>
I wonder how that is possible, since the VM is stopped during 'colo' state. Unrelated to this patch, I think this area needs some work since the following unintended runstate transition is possible: 'shutdown' -> 'colo' -> 'running'. > --- > softmmu/runstate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c > index 636aab0..455ad0d 100644 > --- a/softmmu/runstate.c > +++ b/softmmu/runstate.c > @@ -125,6 +125,7 @@ static const RunStateTransition > runstate_transitions_def[] = { > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH }, > > { RUN_STATE_COLO, RUN_STATE_RUNNING }, > + { RUN_STATE_COLO, RUN_STATE_SHUTDOWN}, > > { RUN_STATE_RUNNING, RUN_STATE_DEBUG }, > { RUN_STATE_RUNNING, RUN_STATE_INTERNAL_ERROR }, --
pgpWfUClGnK25.pgp
Description: OpenPGP digital signature