On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> It's better to pass &error_abort than just assert that result is 0: on
> crash, we'll immediately see the reason in the backtrace.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
> ---
> include/block/block_int.h | 2 +-
> block/file-posix.c | 2 +-
> block/io.c | 29 ++++++++++++++++++++++-------
> tests/test-write-threshold.c | 5 +++--
> 4 files changed, 27 insertions(+), 11 deletions(-)
> +++ b/block/io.c
> @@ -898,17 +898,34 @@ static bool coroutine_fn
> bdrv_wait_serialising_requests(BdrvTrackedRequest *self
> return waited;
> }
>
> -int bdrv_check_request(int64_t offset, int64_t bytes)
> +int bdrv_check_request(int64_t offset, int64_t bytes, Error **errp)
> {
Merge conflicts with 8ac5aab255 here and later in the series, but I
think I managed to resolve all the differences. I'm planning to queue
this through my NBD tree after subjecting it to more testing.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
