On 1/28/21 11:36 PM, David Gibson wrote: > On Thu, Jan 28, 2021 at 08:02:41AM +0100, Cédric Le Goater wrote: >> On 1/28/21 1:45 AM, Joel Stanley wrote: >>> On Tue, 26 Jan 2021 at 17:11, Cédric Le Goater <c...@kaod.org> wrote: >>>> >>>> The current settings are useful to load large kernels (with debug) but >>>> it moves the initrd image in a memory region not protected by >>>> skiboot. If skiboot is compiled with DEBUG=1, memory poisoning will >>>> corrupt the initrd. >>>> >>>> Cc: Murilo Opsfelder Araujo <muri...@linux.ibm.com> >>>> Signed-off-by: Cédric Le Goater <c...@kaod.org> >>> >>> Reviewed-by: Joel Stanley <j...@jms.id.au> >>> >>> Note that the machine's default ram size will change with this patch: >>> >>> mc->default_ram_size = INITRD_LOAD_ADDR + INITRD_MAX_SIZE; >> >> Ah yes. I missed that. >> >>> So we will go from 1.75GB to 768MB. Does anything break when the >>> machine has less than 1GB of ram? >> >> There is a warning if the machine has less than 1GB but we should >> also change the default RAM size to 1G to be on the safe side. > > I've merged the patch, but I'm happy to replace it with an updated > version, or fold in a change, if that helps.
I will send a little fix to set the default RAM size of the machine. Thanks, C.
