Hi On Fri, Jan 29, 2021 at 11:56 PM Paolo Bonzini <pbonz...@redhat.com> wrote: > > On 29/01/21 20:49, Peter Maydell wrote: > > On Fri, 29 Jan 2021 at 11:33, Paolo Bonzini <pbonz...@redhat.com> wrote: > >> > >> The following changes since commit > >> 0bcd12fb1513bad44f05f2d3a8eef2a99b3077b6: > >> > >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > >> staging (2021-01-28 12:30:30 +0000) > >> > >> are available in the Git repository at: > >> > >> https://gitlab.com/bonzini/qemu.git tags/for-upstream > >> > >> for you to fetch changes up to 6c52f4644c9c8a18b8495e169e539632a897f135: > >> > >> accel/kvm/kvm-all: Fix wrong return code handling in dirty log code > >> (2021-01-29 10:38:38 +0100) > >> > >> ---------------------------------------------------------------- > > > > Fails to build, OSX: > > > > ../../subprojects/libslirp/src/slirp.c:131:17: error: unused variable > > 'old_stat' [-Werror,-Wunused-variable] > > struct stat old_stat; > > ^ > > ../../subprojects/libslirp/src/slirp.c:143:10: error: unused variable > > 'buff' [-Werror,-Wunused-variable] > > char buff[512]; > > ^ > > Hmm this is the same slirp failure that in theory should have been fixed > by Marc-André. I'll check again on Monday. > >
That's weird, https://patchew.org/QEMU/20210129111814.566629-1-pbonz...@redhat.com/20210129111814.566629-24-pbonz...@redhat.com/ -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece +Subproject commit 5dce846e3ee82d93462bc637bb0db2fd49f0fc5a I can't really explain why the submodule wasn't updated to include the fix. Peter, did this fail on various CI builds or during a manual build? -- Marc-André Lureau
