On 2/3/21 11:04 AM, Daniel P. Berrangé wrote: > On Tue, Feb 02, 2021 at 09:58:13PM +0100, Philippe Mathieu-Daudé wrote: >> Follow the inclusive terminology from the "Conscious Language in your >> Open Source Projects" guidelines [*] and replace the words "whitelist" >> appropriately. >> >> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md >> >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> ui/console.c | 2 +- >> ui/vnc-auth-sasl.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >>
>> diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c >> index f67111a3662..dde4b8d4144 100644 >> --- a/ui/vnc-auth-sasl.c >> +++ b/ui/vnc-auth-sasl.c >> @@ -288,7 +288,7 @@ static int protocol_client_auth_sasl_step(VncState *vs, >> uint8_t *data, size_t le >> goto authreject; >> } >> >> - /* Check username whitelist ACL */ >> + /* Check username allowlist ACL */ > > ACL expands to "access control list" so this original comment > was already redundant, and so is the replacement. Using > acronyms is bad practice, so I'd suggest we go for > > "Check the username access control list" OK will do, thanks.
