On 2/8/21 5:33 PM, Daniel P. Berrangé wrote: > This series fixes a problem with our gitlab CI rules that cause > container builds to be skipped. See the commit description in the > first patch for the details on this problem. ...
> There is still a race condition though where build jobs can run > with the wrong containers. This happens if you push two different > branches to gitlab with different docker file content. If the > container jobs for the 2nd branch finish before the 1st > branch runs its build jobs, the 1st branch can end up using > containers fro the second branch. The only fix to truely fix > that would be to stop using "latest" docker tag and always > use a tag based on the branch name. This would mean we build > up a growing set of docker images in the gitlab registry. OK this indeed describes the problem I'm facing. > At least this series is much more correct that what exists in > git currently. Good, I'll test it then. Regards, Phil.