On 2/19/21 12:33 AM, Richard Henderson wrote: > On 2/18/21 3:11 PM, Philippe Mathieu-Daudé wrote: >>> @@ -533,7 +520,7 @@ uintptr_t QEMU_DISABLE_CFI >>> tcg_qemu_tb_exec(CPUArchState *env, >>> tci_write_reg(regs, t0, *(uint32_t *)(t1 + t2)); >>> break; >>> CASE_32_64(st8) >>> - t0 = tci_read_r8(regs, &tb_ptr); >>> + t0 = tci_read_r(regs, &tb_ptr); >> >> No need for tb_ptr++ here? > > Done in tcg_read_b, called by tci_read_r.
Doh I missed it is done in tci_read_r() indeed. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>