On Tue, Feb 23, 2021 at 11:52:17AM -0300, Wainer dos Santos Moschetta wrote:
> Hi Cleber,
>
> In case you need to send a v2, mind to add the following patch together?
>
> commit 3c4ed8a78e096e4d7df0398c29887a9d468ae120 (HEAD -> gitlab_runners)
> Author: Wainer dos Santos Moschetta <waine...@redhat.com>
> Date: Tue Feb 23 11:26:08 2021 -0300
>
> scripts/ci/gitlab-pipeline-status: Handle ValueError exceptions nicely
>
> With this change, when getting the local branch, it will handle nicely
> any threw ValueError exception instead of print the stack trace.
>
> Signed-off-by: Wainer dos Santos Moschetta <waine...@redhat.com>
>
> diff --git a/scripts/ci/gitlab-pipeline-status
> b/scripts/ci/gitlab-pipeline-status
> index 924db327ff..6177df973a 100755
> --- a/scripts/ci/gitlab-pipeline-status
> +++ b/scripts/ci/gitlab-pipeline-status
> @@ -160,7 +160,11 @@ def main():
> args = parser.parse_args()
>
> if not args.commit:
> - args.commit = get_local_branch_commit(args.branch)
> + try:
> + args.commit = get_local_branch_commit(args.branch)
> + except ValueError as error:
> + print("ERROR: %s" % error)
> + sys.exit(1)
1 is the default error code, so you should pass the error message to sys.exit
directly without the print. If you don't want that, at least redirect the
print to sys.stderr.
Erik
