John Snow <js...@redhat.com> writes: > There's not a big obvious difference between the types of checks that > happen in the main function versus the kind that happen in the > functions. Now they're in one place for each of the main types. > > As part of the move, spell out the required and optional keywords so > they're obvious at a glance. Use tuples instead of lists for immutable > data, too. > > Signed-off-by: John Snow <js...@redhat.com> > Reviewed-by: Cleber Rosa <cr...@redhat.com>
No objection to changing read-only lists to tuples (applies to previous patch, too). No objection to turning positional into keyword arguments where that improves clarity. I have doubts on the code motion. Yes, the checks for each type are now together. On the other hand, the check_keys() are now separate. I can no longer see all the keys at a glance.
