> -----Original Message----- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, February 25, 2021 5:08 PM > To: Chenqun (kuhn) <kuhn.chen...@huawei.com> > Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; lviv...@redhat.com; > th...@redhat.com; Zhanghailiang <zhang.zhanghaili...@huawei.com>; ganqixin > <ganqi...@huawei.com> > Subject: Re: [PATCH] qtest: delete redundant qtest.h header files > > Chen Qun <kuhn.chen...@huawei.com> writes: > > > There are 23 files that include the "sysemu/qtest.h", but they do not > > use any qtest functions. > > > > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> > > The subject sounds as if you were deleting file include/sysemu/qtest.h, which > would be wrong. You're actually deleting inclusions. Suggest to say > > qtest: delete superfluous inclusions of qtest.h This subject is good to me. Thanks for your point ! I will change it in v2.
> > or > > delete superfluous #include "sysemu/qtest.h" > > Perhaps the maintainer merging your patch can do that for you.
