Patchew URL: https://patchew.org/QEMU/1614329353-2124-1-git-send-email-wangxinga...@huawei.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1614329353-2124-1-git-send-email-wangxinga...@huawei.com Subject: [RFC PATCH 0/4] hw/arm/virt-acpi-build: Introduce iommu option for pci root bus === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1614329353-2124-1-git-send-email-wangxinga...@huawei.com -> patchew/1614329353-2124-1-git-send-email-wangxinga...@huawei.com Switched to a new branch 'test' baed0b1 hw/arm/virt-acpi-build: Add explicit idmap info in IORT table bf70832 hw/pci: Add pci_root_bus_max_bus ddfb0cc hw/pci: Add iommu option for pci root bus ab317df pci: Add PCI_BUS_IOMMU property === OUTPUT BEGIN === 1/4 Checking commit ab317dff3b76 (pci: Add PCI_BUS_IOMMU property) 2/4 Checking commit ddfb0ccbed8b (hw/pci: Add iommu option for pci root bus) ERROR: suspect code indent for conditional statements (4, 7) #105: FILE: hw/pci-bridge/pci_expander_bridge.c:258: + if (pxb->iommu) { + bus->flags |= PCI_BUS_IOMMU; total: 1 errors, 0 warnings, 98 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit bf70832f4742 (hw/pci: Add pci_root_bus_max_bus) 4/4 Checking commit baed0b179ccc (hw/arm/virt-acpi-build: Add explicit idmap info in IORT table) ERROR: trailing statements should be on next line #52: FILE: hw/arm/virt-acpi-build.c:269: + if (!pci_bus_is_root(bus)) continue; ERROR: braces {} are necessary for all arms of this statement #52: FILE: hw/arm/virt-acpi-build.c:269: + if (!pci_bus_is_root(bus)) continue; [...] ERROR: trailing statements should be on next line #96: FILE: hw/arm/virt-acpi-build.c:328: + if (!pci_bus_has_iommu(bus)) continue; ERROR: braces {} are necessary for all arms of this statement #96: FILE: hw/arm/virt-acpi-build.c:328: + if (!pci_bus_has_iommu(bus)) continue; [...] total: 4 errors, 0 warnings, 139 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1614329353-2124-1-git-send-email-wangxinga...@huawei.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
