Hi Richard,
On 2/28/21 12:25 AM, Richard Henderson wrote:
> Add a flag to MIPSCPUClass in order to avoid needing to
> replace mips_tcg_ops.do_transaction_failed.
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> target/mips/cpu-qom.h | 3 +++
> hw/mips/jazz.c | 35 +++--------------------------------
> target/mips/op_helper.c | 3 ++-
> 3 files changed, 8 insertions(+), 33 deletions(-)
>
> diff --git a/target/mips/cpu-qom.h b/target/mips/cpu-qom.h
> index 826ab13019..dda0c911fa 100644
> --- a/target/mips/cpu-qom.h
> +++ b/target/mips/cpu-qom.h
> @@ -47,6 +47,9 @@ struct MIPSCPUClass {
> DeviceRealize parent_realize;
> DeviceReset parent_reset;
> const struct mips_def_t *cpu_def;
> +
> + /* Used for the jazz board to modify mips_cpu_do_transaction_failed. */
Isn't it possible to have other (old) boards doing something similar?
If so any target can overload its CPUClass with the same boolean,
so:
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> + bool no_data_aborts;
> };
