On 3/9/21 5:00 PM, huang...@chinatelecom.cn wrote:
> From: Hyman <huang...@chinatelecom.cn>
>
> The test aborts and error message as the following be throwed:
> "No such file or directory: '/var/tmp/qemu-migrate-{pid}.migrate",
> when the unix socket migration test nearly done. The reason is
> qemu removes the unix socket file after migration before
> guestperf.py script do it. So pre-check if the socket file exists
> when removing it to prevent the guestperf program from aborting.
>
> Signed-off-by: Hyman <huang...@chinatelecom.cn>
> ---
> tests/migration/guestperf/engine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Interesting, we have in MAINTAINERS:
Python scripts
M: Eduardo Habkost <ehabk...@redhat.com>
M: Cleber Rosa <cr...@redhat.com>
S: Odd Fixes
F: scripts/*.py
F: tests/*.py
However:
./scripts/get_maintainer.pl -f tests/migration/guestperf/engine.py
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
> diff --git a/tests/migration/guestperf/engine.py
> b/tests/migration/guestperf/engine.py
> index 83bfc3b..86d4f21 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -405,7 +405,7 @@ def run(self, hardware, scenario, result_dir=os.getcwd()):
> progress_history = ret[0]
> qemu_timings = ret[1]
> vcpu_timings = ret[2]
> - if uri[0:5] == "unix:":
> + if uri[0:5] == "unix:" and os.path.exists(uri[5:]):
> os.remove(uri[5:])
> if self._verbose:
> print("Finished migration")
>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
