ui/cocoa used to raise all keys before it resigns active to prevent a stuck key problem caused by key up events it does not see while it is inactive. The problem is solved by checking -[NSEvent modifierFlags] in commit 6d73bb643aa725348aabe6a885ac5fb0b7f70252, which is better because it handles the case that key *down* events are missed while it is inactive.
Signed-off-by: Akihiko Odaki <akihiko.od...@gmail.com> --- ui/cocoa.m | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index a7848ae0a30..ac8989947f5 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -326,7 +326,6 @@ - (BOOL) isAbsoluteEnabled; - (float) cdx; - (float) cdy; - (QEMUScreen) gscreen; -- (void) raiseAllKeys; @end QemuCocoaView *cocoaView; @@ -996,18 +995,6 @@ - (BOOL) isAbsoluteEnabled {return isAbsoluteEnabled;} - (float) cdx {return cdx;} - (float) cdy {return cdy;} - (QEMUScreen) gscreen {return screen;} - -/* - * Makes the target think all down keys are being released. - * This prevents a stuck key problem, since we will not see - * key up events for those keys after we have lost focus. - */ -- (void) raiseAllKeys -{ - with_iothread_lock(^{ - qkbd_state_lift_all_keys(kbd); - }); -} @end @@ -1143,13 +1130,6 @@ - (BOOL)windowShouldClose:(id)sender return NO; } -/* Called when QEMU goes into the background */ -- (void) applicationWillResignActive: (NSNotification *)aNotification -{ - COCOA_DEBUG("QemuCocoaAppController: applicationWillResignActive\n"); - [cocoaView raiseAllKeys]; -} - /* We abstract the method called by the Enter Fullscreen menu item * because Mac OS 10.7 and higher disables it. This is because of the * menu item's old selector's name toggleFullScreen: -- 2.24.3 (Apple Git-128)