On 3/10/21 12:24 PM, Richard Henderson wrote:
On 3/9/21 6:29 PM, Rebecca Cran wrote:
+void tlb_flush_page_range_by_mmuidx(CPUState *cpu, target_ulong addr,
+                                    unsigned int num_pages, uint16_t idxmap)

I am not keen on this interface.  I think you should take either start+end addresses (inclusive) or start+length (in bytes).

Using num_pages, and as an unsigned int, seems too easy to fail when applied to a different guest.

Do you mean pushing the knowledge of the number of pages to invalidate down to cputlb.c? Because I'm thinking there has to be a loop somewhere that invalidates each page if a full flush isn't being done?

--
Rebecca Cran

Reply via email to